Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6247625674194944: Issue 299 and issue 385 - Drop support for RC4 and support IE6/WinXP clients (Closed)

Created:
April 26, 2014, 10:05 p.m. by Wladimir Palant
Modified:
April 28, 2014, 10:34 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 299 and issue 385 - Drop support for RC4 and support IE6/WinXP clients

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Slightly adjusted ciphers list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M modules/nginx/templates/nginx.conf.erb View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
April 26, 2014, 10:05 p.m. (2014-04-26 22:05:25 UTC) #1
Felix Dahlke
LGTM, feel free to address my comment if it makes sense. http://codereview.adblockplus.org/6247625674194944/diff/5741031244955648/modules/nginx/templates/nginx.conf.erb File modules/nginx/templates/nginx.conf.erb (right): ...
April 26, 2014, 10:19 p.m. (2014-04-26 22:19:47 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6247625674194944/diff/5741031244955648/modules/nginx/templates/nginx.conf.erb File modules/nginx/templates/nginx.conf.erb (right): http://codereview.adblockplus.org/6247625674194944/diff/5741031244955648/modules/nginx/templates/nginx.conf.erb#newcode42 modules/nginx/templates/nginx.conf.erb:42: ssl_ciphers "EECDH+ECDSA+AESGCM EECDH+aRSA+AESGCM EECDH+ECDSA+SHA384 EECDH+ECDSA+SHA256 EECDH+aRSA+SHA384 EECDH+aRSA+SHA256 EECDH EDH+aRSA ...
April 27, 2014, 8:35 p.m. (2014-04-27 20:35:34 UTC) #3
Felix Dahlke
April 28, 2014, 10:30 a.m. (2014-04-28 10:30:34 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld