Issue 1196 - Fix dealing with boolean VARIANT

src/plugin/PluginUserSettings.cpp

 #include "PluginStdAfx.h"
 #include "PluginUserSettings.h"
 #include <algorithm>
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "../shared/Dictionary.h"
 
 static const CString s_GetMessage = L"GetMessage";
 static const CString s_GetLanguageCount = L"GetLanguageCount";
 static const CString s_GetLanguageByIndex = L"GetLanguageByIndex";
@@ skipping 313 matching lines @@
 
     pVarResult->vt = VT_BSTR;
     pVarResult->bstrVal = SysAllocString(settings->GetDocumentationLink());
   }
   else if (s_IsAcceptableAdsEnabled == method)
   {
     if (0 != pDispparams->cArgs)
       return DISP_E_BADPARAMCOUNT;
 
     pVarResult->vt = VT_BOOL;
-    pVarResult->boolVal = CPluginClient::GetInstance()->IsAcceptableAdsEnabled();
+    pVarResult->boolVal = CPluginClient::GetInstance()->IsAcceptableAdsEnabled() ? VARIANT_TRUE : VARIANT_FALSE;
   }
   else if (s_SetAcceptableAdsEnabled == method)
   {
     if (1 != pDispparams->cArgs)
       return DISP_E_BADPARAMCOUNT;
 
     if (VT_BOOL != pDispparams->rgvarg[0].vt)
       return DISP_E_TYPEMISMATCH;
 
-    bool enable = pDispparams->rgvarg[0].boolVal;
+    bool enable = VARIANT_FALSE != pDispparams->rgvarg[0].boolVal;
 
     if (enable)
     {
       CPluginClient* client = CPluginClient::GetInstance();
       client->AddSubscription(client->GetPref(L"subscriptions_exceptionsurl", L""));
     }
     else
     {
       CPluginClient* client = CPluginClient::GetInstance();
       client->RemoveSubscription(client->GetPref(L"subscriptions_exceptionsurl", L""));
     }
   }
   else if (s_IsUpdate == method)
   {
     if (0 != pDispparams->cArgs)
       return DISP_E_BADPARAMCOUNT;
 
     pVarResult->vt = VT_BOOL;
     pVarResult->boolVal = CPluginClient::GetInstance()->GetPref(L"displayUpdatePage", false);
   }
   else
     return DISP_E_MEMBERNOTFOUND;
 
   return S_OK;
 }