Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6248869830590464: Issue 1196 - Fix dealing with boolean VARIANT (Closed)

Created:
Aug. 12, 2014, 11:10 a.m. by sergei
Modified:
Sept. 1, 2014, 11:08 a.m.
Visibility:
Public.

Description

Fix dealing with boolean VARIANT and get rid of warning about forcing of the type conversion.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/plugin/PluginUserSettings.cpp View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5
sergei
Aug. 12, 2014, 11:17 a.m. (2014-08-12 11:17:08 UTC) #1
Eric
I've been in the middle of reworking this same piece of code. The following review ...
Aug. 12, 2014, 12:49 p.m. (2014-08-12 12:49:38 UTC) #2
sergei
No one of your reviews contains the fixed mistake.
Aug. 12, 2014, 1:30 p.m. (2014-08-12 13:30:47 UTC) #3
Felix Dahlke
LGTM from my side. There's indeed a review touching the same code, but it should ...
Aug. 12, 2014, 3:58 p.m. (2014-08-12 15:58:58 UTC) #4
Oleksandr
Aug. 21, 2014, 4:41 p.m. (2014-08-21 16:41:16 UTC) #5
Actually a bit surprised it worked before :) LGTM

Powered by Google App Engine
This is Rietveld