Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6249914833043456: Issue 1731 - Fixed locale code for Gujarati (Closed)

Created:
Dec. 22, 2014, 12:22 p.m. by Sebastian Noack
Modified:
Dec. 28, 2014, 4:07 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1731 - Fixed locale code for Gujarati

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't convert locale code for Firefox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M localeTools.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
Dec. 22, 2014, 12:24 p.m. (2014-12-22 12:24:01 UTC) #1
kzar
The issue mentions the language code is "gu" not "gu_IN" for Chrome. You seem to ...
Dec. 22, 2014, 1:07 p.m. (2014-12-22 13:07:27 UTC) #2
Sebastian Noack
On 2014/12/22 13:07:27, kzar wrote: > The issue mentions the language code is "gu" not ...
Dec. 22, 2014, 1:13 p.m. (2014-12-22 13:13:33 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6249914833043456/diff/5629499534213120/localeTools.py File localeTools.py (right): http://codereview.adblockplus.org/6249914833043456/diff/5629499534213120/localeTools.py#newcode21 localeTools.py:21: 'gu': 'gu-IN', This is wrong. I checked https://addons.mozilla.org/en-US/firefox/addon/gujarati-in-language-pack/ and ...
Dec. 28, 2014, 11:26 a.m. (2014-12-28 11:26:28 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/6249914833043456/diff/5629499534213120/localeTools.py File localeTools.py (right): http://codereview.adblockplus.org/6249914833043456/diff/5629499534213120/localeTools.py#newcode21 localeTools.py:21: 'gu': 'gu-IN', On 2014/12/28 11:26:28, Wladimir Palant wrote: > ...
Dec. 28, 2014, 12:53 p.m. (2014-12-28 12:53:15 UTC) #5
kzar
LGTM
Dec. 28, 2014, 2:07 p.m. (2014-12-28 14:07:03 UTC) #6
Wladimir Palant
Dec. 28, 2014, 2:13 p.m. (2014-12-28 14:13:07 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld