Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 6250418359238656: Issue 153 - Added tests for io.js and updated filter storage tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by Wladimir Palant
Modified:
5 years, 7 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 153 - Added tests for io.js and updated filter storage tests to no longer require reading from URL.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -15 lines) Patch
M chrome/content/common.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/content/tests/filterStorage_readwrite.js View 5 chunks +44 lines, -15 lines 0 comments Download
A chrome/content/tests/io.js View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
5 years, 7 months ago (2014-03-21 13:15:53 UTC) #1
Felix Dahlke
5 years, 7 months ago (2014-03-22 00:28:54 UTC) #2
LGTM. The tests could go a bit further, but it looks like our code is pretty
much covered - testing OS.File shouldn't be necessary.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5