Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6250418359238656: Issue 153 - Added tests for io.js and updated filter storage tests (Closed)

Created:
March 21, 2014, 1:15 p.m. by Wladimir Palant
Modified:
March 22, 2014, 9:04 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 153 - Added tests for io.js and updated filter storage tests to no longer require reading from URL.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -15 lines) Patch
M chrome/content/common.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/content/tests/filterStorage_readwrite.js View 5 chunks +44 lines, -15 lines 0 comments Download
A chrome/content/tests/io.js View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
March 21, 2014, 1:15 p.m. (2014-03-21 13:15:53 UTC) #1
Felix Dahlke
March 22, 2014, 12:28 a.m. (2014-03-22 00:28:54 UTC) #2
LGTM. The tests could go a bit further, but it looks like our code is pretty
much covered - testing OS.File shouldn't be necessary.

Powered by Google App Engine
This is Rietveld