jshydra.js - Issue 6256752412590080: Issue 301 - jshydra: Handle for .. of ..

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: jshydra.js

Issue 6256752412590080: Issue 301 - jshydra: Handle for .. of .. (Closed)

Patch Set: Created April 10, 2014, 5:05 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 var include = function(file)	1 var include = function(file)

2 {	2 {

3 if (typeof include.dirStack == "undefined")	3 if (typeof include.dirStack == "undefined")

4 include.dirStack = [];	4 include.dirStack = [];

5	5

6 if (include.dirStack.length && !/^([a-zA-Z]:)?[\/\\]/.test(file))	6 if (include.dirStack.length && !/^([a-zA-Z]:)?[\/\\]/.test(file))

7 file = include.dirStack[include.dirStack.length - 1] + "/../" + file;	7 file = include.dirStack[include.dirStack.length - 1] + "/../" + file;

8 while (/\/[^.\/][^\/]*\/\.\.(?=\/)/.test(file))	8 while (/\/[^.\/][^\/]*\/\.\.(?=\/)/.test(file))

9 file = file.replace(/\/[^.\/][^\/]*\/\.\.(?=\/)/, "");	9 file = file.replace(/\/[^.\/][^\/]*\/\.\.(?=\/)/, "");

10	10

(...skipping 22 matching lines...) Expand all Loading...
33 scriptArgs.splice(i--, 2);	33 scriptArgs.splice(i--, 2);

34 }	34 }

35 }	35 }

36	36

37 if (!scriptArgs.length)	37 if (!scriptArgs.length)

38 throw Error("No script to execute");	38 throw Error("No script to execute");

39 include(scriptArgs[0]);	39 include(scriptArgs[0]);

40	40

41 for (var i = 1; i < scriptArgs.length; i++)	41 for (var i = 1; i < scriptArgs.length; i++)

42 process_js(Reflect.parse(read(scriptArgs[i])), scriptArgs[i], scriptArg);	42 process_js(Reflect.parse(read(scriptArgs[i])), scriptArgs[i], scriptArg);

43 })(arguments);	43 })(this.arguments \|\| this.scriptArgs);
	Wladimir Palant 2014/04/10 17:15:10 I don't really get this change, mind explaining? I don't really get this change, mind explaining?
OLD	NEW

« no previous file with comments | « no previous file | scripts/abprewrite.js » ('j') | no next file with comments »