Issue 301 - jshydra: Handle for .. of ..

jshydra: Handle for .. of ..

[tschuster, 2014-04-10 17:10:49]

review please

[Wladimir Palant, 2014-04-10 17:15:10]

Looks good except for the change I commented on.

http://codereview.adblockplus.org/6256752412590080/diff/5629499534213120/jshy...
File jshydra.js (right):

http://codereview.adblockplus.org/6256752412590080/diff/5629499534213120/jshy...
jshydra.js:43: })(this.arguments || this.scriptArgs);
I don't really get this change, mind explaining?

[tschuster, 2014-04-10 18:06:48]

On 2014/04/10 17:15:10, Wladimir Palant wrote:
> Looks good except for the change I commented on.
> 
>
http://codereview.adblockplus.org/6256752412590080/diff/5629499534213120/jshy...
> File jshydra.js (right):
> 
>
http://codereview.adblockplus.org/6256752412590080/diff/5629499534213120/jshy...
> jshydra.js:43: })(this.arguments || this.scriptArgs);
> I don't really get this change, mind explaining?

Newer versions of the SpiderMonkey shell don't have the global arguments
property, it is instead called "scriptsArgs". 
Now that I am thinking about it, do we need to update the js-shell somewhere?
(Is there something like a build server?)

[Wladimir Palant, 2014-04-11 05:42:59]

LGTM

Note that we are currently using SpiderMonkey 17 and not updating - starting
with version 21 its parser rewrites loops into let statements which is something
our code currently cannot undo.

[Wladimir Palant, 2014-04-11 05:58:48]

Actually, no - that change is incomplete. autotest.py will fail this way, please
adjust autotest/abprewrite_source.js, test_abprewrite.js.expected and
test_abprewrite_module.js.expected to test for..of loops.

[tschuster, 2014-04-11 22:26:15]

On 2014/04/11 05:42:59, Wladimir Palant wrote:
> LGTM
> 
> Note that we are currently using SpiderMonkey 17 and not updating - starting
> with version 21 its parser rewrites loops into let statements which is
something
> our code currently cannot undo.
Can you give a code example for that. I would like to fix this.

[tschuster, 2014-04-11 22:51:23]

autotest now passes for me

[Wladimir Palant, 2014-04-12 07:38:17]

LGTM

Actually, it seems that the parser change I was worried about was reverted - let
statements are no longer being produced. I tried the current nightly from
https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-11-03...
and it produced exactly the same file as the old SpiderMonkey 17 build we were
using before. I reopened https://issues.adblockplus.org/ticket/298 - feel free
to take it.