Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6274620759998464: Issue 2450 - [cms] Extra semicolons being added to translatable strings (Closed)

Created:
May 4, 2015, 8:27 p.m. by Wladimir Palant
Modified:
May 5, 2015, 2:53 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 2450 - [cms] Extra semicolons being added to translatable strings

Patch Set 1 #

Total comments: 2

Patch Set 2 : More generic regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cms/converters.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
May 4, 2015, 8:27 p.m. (2015-05-04 20:27:02 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/6274620759998464/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6274620759998464/diff/5629499534213120/cms/converters.py#newcode64 cms/converters.py:64: text = re.sub(r"&(?!\w+;)", "&", text) What's about hexadecimal escapes ...
May 4, 2015, 8:45 p.m. (2015-05-04 20:45:33 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6274620759998464/diff/5629499534213120/cms/converters.py File cms/converters.py (right): http://codereview.adblockplus.org/6274620759998464/diff/5629499534213120/cms/converters.py#newcode64 cms/converters.py:64: text = re.sub(r"&(?!\w+;)", "&", text) On 2015/05/04 20:45:33, Sebastian ...
May 5, 2015, 2:26 p.m. (2015-05-05 14:26:13 UTC) #3
Sebastian Noack
May 5, 2015, 2:40 p.m. (2015-05-05 14:40:28 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld