Issue 356 - Fixed URL for publishing an item on the Chrome Web Store

sitescripts/extensions/bin/createNightlies.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 417 matching lines @@
     # https://developer.chrome.com/webstore/using_webstore_api#publishpublic
 
     request = urllib2.Request('https://www.googleapis.com/chromewebstore/v1.1/items/%s/publish' % self.config.devbuildGalleryID)
     request.get_method = lambda: 'POST'
     request.add_header('Authorization', auth_token)
     request.add_header('x-goog-api-version', '2')
     request.add_header('Content-Length', '0')
 
     response = json.load(opener.open(request))
 
-    if any(status not in ('OK', 'ITEM_PENDING_REVIEW') for status in response['status']):
-      raise Exception(response['statusDetail'])

[Wladimir Palant, 2014/05/06 08:05:48]

I don't know where you got the status code OK from (the documentation doesn't
mention it and I couldn't find any other sources either) but even if it is
correct - we should still have the status field in the exception in addition to
statusDetail.

[Sebastian Noack, 2014/05/06 08:18:50]

Done.

+    if any(status != 'ITEM_PENDING_REVIEW' for status in response['status']):
+      raise Exception({'status': response['status'], 'statusDetail': response['statusDetail']})
 
   def run(self):
     """
       Run the nightly build process for one extension
     """
     try:
       if self.config.type == 'ie':
         # We cannot build IE builds, simply list the builds already in
         # the directory. Basename has to be deduced from the repository name.
         self.basename = os.path.basename(self.config.repository)
@@ skipping 66 matching lines @@
     except Exception, ex:
       print >>sys.stderr, "The build for %s failed:" % repo
       traceback.print_exc()
 
   file = open(nightlyConfigFile, 'wb')
   nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
   main()