Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6282207912001536: Issue 356 - Fixed URL for publishing an item on the Chrome Web Store (Closed)

Created:
May 6, 2014, 6:45 a.m. by Sebastian Noack
Modified:
May 6, 2014, 8:37 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 356 - Fixed URL for publishing an item on the Chrome Web Store

Patch Set 1 #

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
May 6, 2014, 6:48 a.m. (2014-05-06 06:48:38 UTC) #1
Wladimir Palant
As mentioned in the issue, this is not sufficient. Please make sure to report the ...
May 6, 2014, 6:51 a.m. (2014-05-06 06:51:05 UTC) #2
Sebastian Noack
May 6, 2014, 7:44 a.m. (2014-05-06 07:44:55 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/6282207912001536/diff/5178081291534336/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6282207912001536/diff/5178081291534336/sitescripts/extensions/bin/createNightlies.py#newcode439 sitescripts/extensions/bin/createNightlies.py:439: raise Exception(response['statusDetail']) I don't know where you got the ...
May 6, 2014, 8:05 a.m. (2014-05-06 08:05:48 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/6282207912001536/diff/5178081291534336/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6282207912001536/diff/5178081291534336/sitescripts/extensions/bin/createNightlies.py#newcode439 sitescripts/extensions/bin/createNightlies.py:439: raise Exception(response['statusDetail']) On 2014/05/06 08:05:48, Wladimir Palant wrote: > ...
May 6, 2014, 8:18 a.m. (2014-05-06 08:18:50 UTC) #5
Wladimir Palant
May 6, 2014, 8:31 a.m. (2014-05-06 08:31:43 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld