Issue 6287762160353280: Fixed: patterns.ini contents are being processed multiple times

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6287762160353280: Fixed: patterns.ini contents are being processed multiple times (Closed)

Created:
March 16, 2014, 9:29 p.m. by Wladimir Palant

Modified:
March 18, 2014, 7:09 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/152 - our own code handles reentrance just fine, XMLHttpRequest however doesn`t. If a new progress event fires while the previous one is still being processed request.response isn`t being reset. The solution is to decouple our event processing using Utils.runAsync. While at it, it seems that error reporting was always broken here - fixed it.

Patch Set 1 #

Patch Set 2 : Fixed typo #

Patch Set 3 : Fixed error reporting #

Created: March 16, 2014, 9:49 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -24 lines)			Patch
	M	lib/io.js	View	1 2	4 chunks	+30 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages