Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/url.js

Issue 6289648649240576: Issue 1852 - Fixed a TypeError on Safari caused by parsing empty URLs (Closed)
Patch Set: Created Jan. 22, 2015, 4:25 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 window.URL = (function() 18 window.URL = (function()
19 { 19 {
20 let URL = window.URL || window.webkitURL; 20 let URL = window.URL || window.webkitURL;
21 let URLProperties = ["href", "protocol", "host", "hostname", "port", "pathname ", "search"]; 21 let URLProperties = ["href", "protocol", "host", "hostname", "port", "pathname ", "search"];
22 22
23 if (!URL || !URLProperties.every(prop => prop in new URL(""))) 23 if (!URL || !URLProperties.every(prop => prop in new URL("about:blank")))
24 { 24 {
25 let doc = document.implementation.createHTMLDocument(); 25 let doc = document.implementation.createHTMLDocument();
26 26
27 let base = doc.createElement("base"); 27 let base = doc.createElement("base");
28 doc.head.appendChild(base); 28 doc.head.appendChild(base);
29 29
30 let anchor = doc.createElement("a"); 30 let anchor = doc.createElement("a");
31 doc.body.appendChild(anchor); 31 doc.body.appendChild(anchor);
32 32
33 URL = function(url, baseUrl) 33 URL = function(url, baseUrl)
34 { 34 {
35 if (baseUrl instanceof URL) 35 if (baseUrl instanceof URL)
36 base.href = baseUrl.href; 36 base.href = baseUrl.href;
37 else 37 else
38 base.href = baseUrl || ""; 38 base.href = baseUrl || "";
39 anchor.href = url; 39 anchor.href = url;
40 40
41 for (let prop of URLProperties) 41 for (let prop of URLProperties)
42 this[prop] = anchor[prop]; 42 this[prop] = anchor[prop];
43 }; 43 };
44 } 44 }
45 45
46 return URL; 46 return URL;
47 })(); 47 })();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld