Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6289648649240576: Issue 1852 - Fixed a TypeError on Safari caused by parsing empty URLs (Closed)

Created:
Jan. 22, 2015, 4:25 p.m. by Sebastian Noack
Modified:
Jan. 22, 2015, 7:01 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1852 - Fixed a TypeError on Safari caused by parsing empty URLs

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/url.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Jan. 22, 2015, 4:25 p.m. (2015-01-22 16:25:52 UTC) #1
kzar
Oh shucks, LGTM!
Jan. 22, 2015, 4:29 p.m. (2015-01-22 16:29:03 UTC) #2
Wladimir Palant
Jan. 22, 2015, 7:01 p.m. (2015-01-22 19:01:26 UTC) #3
Interestingly, it's Chrome's behavior that seems to be non-standard here. LGTM

Powered by Google App Engine
This is Rietveld