Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: adblockplus/metadata.gecko
Issue
6302236728623104
:
Add Adblock Plus API (Closed)
Patch Set: Rebase after change in http://codereview.adblockplus.org/5924365505921024
Created March 17, 2015, 3:30 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Nit: Requires ordered alphabetically by module name
Patch Set 3: Remove redundant check
Patch Set 4: Nit: Use == instead of === as the Mozilla coding style says
Patch Set 5: Remove obsolete require
Patch Set 6: Simplify setter
Patch Set 7: Rebase after change in http://codereview.adblockplus.org/5924365505921024
Right:
Patch Set 1: None
Patch Set 2: Nit: Requires ordered alphabetically by module name
Patch Set 3: Remove redundant check
Patch Set 4: Nit: Use == instead of === as the Mozilla coding style says
Patch Set 5: Remove obsolete require
Patch Set 6: Simplify setter
Patch Set 7: Rebase after change in http://codereview.adblockplus.org/5924365505921024
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
adblockplus/Api.jsm
adblockplus/build.py
adblockplus/metadata.gecko
dependencies
mobile/android/build.mk
View unified diff
|
Download patch
« no previous file with comments
|
« adblockplus/build.py
('k') |
dependencies »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
[default]
2
inherit = adblockplus/metadata.gecko
3
4
[mapping]
5
chrome/content/Api.jsm = Api.jsm
OLD
NEW
« no previous file with comments
|
« adblockplus/build.py
('k') |
dependencies »
('j') |
no next file with comments »
Edit Message
Issue 6302236728623104: Add Adblock Plus API (Closed)
Created March 13, 2015, 10:15 p.m. by Felix Dahlke
Modified May 21, 2015, 11:58 a.m.
Reviewers: Wladimir Palant, René Jeschke
Base URL:
Comments: 3
This is Rietveld