Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6302236728623104: Add Adblock Plus API (Closed)

Created:
March 13, 2015, 10:15 p.m. by Felix Dahlke
Modified:
May 21, 2015, 11:58 a.m.
Visibility:
Public.

Description

Add Adblock Plus API Only supports enabling and disabling Acceptable Ads for now.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit: Requires ordered alphabetically by module name #

Total comments: 2

Patch Set 3 : Remove redundant check #

Patch Set 4 : Nit: Use == instead of === as the Mozilla coding style says #

Patch Set 5 : Remove obsolete require #

Patch Set 6 : Simplify setter #

Patch Set 7 : Rebase after change in http://codereview.adblockplus.org/5924365505921024 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -7 lines) Patch
A adblockplus/Api.jsm View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A adblockplus/build.py View 1 2 3 4 5 6 1 chunk +17 lines, -0 lines 0 comments Download
A adblockplus/metadata.gecko View 1 chunk +5 lines, -0 lines 0 comments Download
M dependencies View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/build.mk View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8
Felix Dahlke
There, it's done. Right now it's unused, but we need it for the ABP settings ...
March 13, 2015, 10:22 p.m. (2015-03-13 22:22:37 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6302236728623104/diff/5649050225344512/adblockplus/Api.jsm File adblockplus/Api.jsm (right): http://codereview.adblockplus.org/6302236728623104/diff/5649050225344512/adblockplus/Api.jsm#newcode45 adblockplus/Api.jsm:45: (subscription) => subscription instanceof DownloadableSubscription && Checking subscription.url is ...
March 14, 2015, 7:53 p.m. (2015-03-14 19:53:04 UTC) #2
Felix Dahlke
New patch set up. http://codereview.adblockplus.org/6302236728623104/diff/5649050225344512/adblockplus/Api.jsm File adblockplus/Api.jsm (right): http://codereview.adblockplus.org/6302236728623104/diff/5649050225344512/adblockplus/Api.jsm#newcode45 adblockplus/Api.jsm:45: (subscription) => subscription instanceof DownloadableSubscription ...
March 14, 2015, 10:56 p.m. (2015-03-14 22:56:11 UTC) #3
Wladimir Palant
LGTM
March 15, 2015, 7:39 p.m. (2015-03-15 19:39:02 UTC) #4
René Jeschke
LGTM
March 15, 2015, 8:15 p.m. (2015-03-15 20:15:27 UTC) #5
Felix Dahlke
Had to rebase after the change in http://codereview.adblockplus.org/5924365505921024.
March 17, 2015, 3:30 p.m. (2015-03-17 15:30:49 UTC) #6
René Jeschke
LGTM
March 18, 2015, 9:03 a.m. (2015-03-18 09:03:27 UTC) #7
Wladimir Palant
March 18, 2015, 3:32 p.m. (2015-03-18 15:32:54 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld