Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6309214725079040: Issue 1409 - Fix some errors in adblockplustest (Closed)

Created:
Sept. 19, 2014, 10:35 a.m. by tschuster
Modified:
Oct. 19, 2014, 9:42 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1409 - Fix some errors in adblockplustest

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/content/httpd.js View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/content/tests/filterStorage.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/content/tests/matcher.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/popupBlocker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/synchronizer.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
tschuster
r?
Sept. 19, 2014, 10:37 a.m. (2014-09-19 10:37:00 UTC) #1
Wladimir Palant
LGTM for the changes to our code. As to httpd.js - we should update to ...
Oct. 14, 2014, 9:05 p.m. (2014-10-14 21:05:12 UTC) #2
tschuster
Oct. 19, 2014, 9:42 p.m. (2014-10-19 21:42:30 UTC) #3
Okay I landed the patch minus the httpd changes.

Powered by Google App Engine
This is Rietveld