Issue 6309488109813760: Issue 2236 - Worked around JsDoc bug with inline annotations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6309488109813760: Issue 2236 - Worked around JsDoc bug with inline annotations (Closed)

Created:
March 30, 2015, 2:11 p.m. by Sebastian Noack

Modified:
April 1, 2015, 8:44 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

This is still WIP. If we agree on doing that I will file an issue. The problem is that current JsDoc 3 crashes when encountering methods with more than one inline-documented argument. Luckily those are only a few in our code. The JsDoc bug: https://github.com/jsdoc3/jsdoc/issues/972

Patch Set 1 #

Created: March 30, 2015, 2:11 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -6 lines)			Patch
M	lib/contentPolicy.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/objectTabs.js	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	lib/requestNotifier.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/utils.js	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

March 30, 2015, 2:23 p.m. (2015-03-30 14:23:39 UTC) #2

LGTM

Not very happy with changing our code to work around tool bugs but I guess
that's indeed the simplest approach.

Expand All Messages | Collapse All Messages