Noissue - Cleaned up message IDs on modules page

Noissue - Cleaned up message IDs on modules page

[saroyanm, 2015-05-21 13:30:29]

Sebastian after reviewing codereview below:
http://codereview.adblockplus.org/5100557458997248

I wanted to also fix the translatable strings on that page, to make it
consistent with last change and have at least one consistently translated page
after migration.

I was thinking how we need to use description in translation files ? 
I was thinking that would be handy to have translation file in locales/en
directory with "message" and "description", so in future would be possible to
copy that file to other locales and modify "messages", please also let me know
if there is already an idea how we are going to deal with the translation.

[saroyanm, 2015-05-21 13:31:46]

Oops, sorry, I mean after reviewing this ->
http://codereview.adblockplus.org/5731153147330560/ codereview

[Sebastian Noack, 2015-05-21 13:51:32]

Note that a few string here are translated in locales/zh_CN/modules.json. So you
have to change the message ids there as well.

On 2015/05/21 13:30:29, saroyanm wrote:
> I was thinking how we need to use description in translation files ? 
> I was thinking that would be handy to have translation file in locales/en
> directory with "message" and "description", so in future would be possible to
> copy that file to other locales and modify "messages", please also let me know
> if there is already an idea how we are going to deal with the translation.

In order to export the source translation, we would need to parse the source
files anyway. So comments could become an additional argument (that is ignored
during runtime) of the translate template filter:

{{ "This text is translated"|translate("msg-id", "This is a comment") }}

[saroyanm, 2015-05-21 14:28:31]

On 2015/05/21 13:51:32, Sebastian Noack wrote:
> Note that a few string here are translated in locales/zh_CN/modules.json. So
you
> have to change the message ids there as well.
Thanks for the info.

> On 2015/05/21 13:30:29, saroyanm wrote:
> > I was thinking how we need to use description in translation files ? 
> > I was thinking that would be handy to have translation file in locales/en
> > directory with "message" and "description", so in future would be possible
to
> > copy that file to other locales and modify "messages", please also let me
know
> > if there is already an idea how we are going to deal with the translation.
> 
> In order to export the source translation, we would need to parse the source
> files anyway. So comments could become an additional argument (that is ignored
> during runtime) of the translate template filter:
> 
> {{ "This text is translated"|translate("msg-id", "This is a comment") }}

But can we use this solution with the files that have HTML extension ? 
It looks like CMS can't understand that syntax when I'm using it in files with
HTML extension.

[Sebastian Noack, 2015-05-21 14:33:14]

On 2015/05/21 14:28:31, saroyanm wrote:
> On 2015/05/21 13:51:32, Sebastian Noack wrote:
> > In order to export the source translation, we would need to parse the source
> > files anyway. So comments could become an additional argument (that is
ignored
> > during runtime) of the translate template filter:
> > 
> > {{ "This text is translated"|translate("msg-id", "This is a comment") }}
> 
> But can we use this solution with the files that have HTML extension ? 
> It looks like CMS can't understand that syntax when I'm using it in files with
> HTML extension.

This isn't currently implemented for any format. I just meant it as a
suggestion. And yes, I were talking about jinja2 based files.

The raw HTML format is merely a legacy from the website migration. New files
should use jinja2 or markdown, and existing raw files should be migrated
eventually.

[saroyanm, 2015-05-21 14:46:51]

On 2015/05/21 14:33:14, Sebastian Noack wrote:
> On 2015/05/21 14:28:31, saroyanm wrote:
> > On 2015/05/21 13:51:32, Sebastian Noack wrote:
> > > In order to export the source translation, we would need to parse the
source
> > > files anyway. So comments could become an additional argument (that is
> ignored
> > > during runtime) of the translate template filter:
> > > 
> > > {{ "This text is translated"|translate("msg-id", "This is a comment") }}
> > 
> > But can we use this solution with the files that have HTML extension ? 
> > It looks like CMS can't understand that syntax when I'm using it in files
with
> > HTML extension.
> 
> This isn't currently implemented for any format. I just meant it as a
> suggestion. And yes, I were talking about jinja2 based files.
> 
> The raw HTML format is merely a legacy from the website migration. New files
> should use jinja2 or markdown, and existing raw files should be migrated
> eventually.

Now got it, thanks. 
Will create a ticket for the feature implementation. Should be handy, so we can
continue the discussion under the ticket in case it's necessary.

Also updated Chinese locale, can you please have a look.

[Sebastian Noack, 2015-05-21 14:50:50]

LGTM. But please fix the the spelling of "Noissue" in the commit message. Also
the title isn't really accurate. This should rather be:

  Noissue - Cleaned up message IDs on modules page