Noissue - Fixed documentation where parameters where mistakently indicated as optional

lib/icon.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 70 matching lines @@
         clearInterval(fadeInInterval);
       }, 100);
     });
   }, 15000);
 }
 
 /**
  * Set the browser action icon for the given page, indicating whether
  * adblocking is active there, and considering the icon animation.
  *
- * @param {Page}    [page]        The page to set the browser action icon for
- * @param {Boolean} [whitelisted] Whether the page has been whitelisted
+ * @param {Page}    page         The page to set the browser action icon for
+ * @param {Boolean} whitelisted  Whether the page has been whitelisted
  */
 function updateIcon(page, whitelisted)
 {
   page.browserAction.setIcon(getIconPath(whitelisted));
   whitelistedState.set(page, whitelisted);
 }
 exports.updateIcon = updateIcon;
 
 /**
  * Starts to animate the browser action icon to indicate a pending notifcation.
  *
- * @param {string} [type] The notifaction type (i.e: "information" or "critical")
+ * @param {string} type  The notifaction type (i.e: "information" or "critical")

[kzar, 2015/03/02 17:09:21]

Nit: "notifaction" looks like a typo.

[Sebastian Noack, 2015/03/02 17:21:38]

Well, this typo isn't matter of this change. But fair enough, lets fix it while
on it.

  */
 function startIconAnimation(type)
 {
   notificationType = type;
 
   if (animationInterval == null)
     animationInterval = runAnimation();
 }
 exports.startIconAnimation = startIconAnimation;
 
 /**
  * Stops to animate the browser action icon.
  */
 function stopIconAnimation()
 {
   if (animationInterval != null)
   {
     clearInterval(animationInterval);
     animationInterval = null;
   }
 
   notificationType  = null;
 }
 exports.stopIconAnimation = stopIconAnimation;