Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6318719470927872: Noissue - Fixed documentation where parameters where mistakently indicated as optional (Closed)

Created:
Feb. 28, 2015, 5:21 p.m. by Sebastian Noack
Modified:
March 3, 2015, 8:29 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Noissue - Fixed documentation where parameters where mistakently indicated as optional

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M lib/icon.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/url.js View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
Feb. 28, 2015, 5:21 p.m. (2015-02-28 17:21:53 UTC) #1
kzar
LGTM http://codereview.adblockplus.org/6318719470927872/diff/5629499534213120/lib/icon.js File lib/icon.js (right): http://codereview.adblockplus.org/6318719470927872/diff/5629499534213120/lib/icon.js#newcode104 lib/icon.js:104: * @param {string} type The notifaction type (i.e: ...
March 2, 2015, 5:09 p.m. (2015-03-02 17:09:21 UTC) #2
kzar
Sorry the L G T M there was a typo of my own! Does _not_ ...
March 2, 2015, 5:15 p.m. (2015-03-02 17:15:10 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/6318719470927872/diff/5629499534213120/lib/icon.js File lib/icon.js (right): http://codereview.adblockplus.org/6318719470927872/diff/5629499534213120/lib/icon.js#newcode104 lib/icon.js:104: * @param {string} type The notifaction type (i.e: "information" ...
March 2, 2015, 5:21 p.m. (2015-03-02 17:21:38 UTC) #4
kzar
LGTM
March 2, 2015, 5:22 p.m. (2015-03-02 17:22:20 UTC) #5
Wladimir Palant
March 2, 2015, 7:18 p.m. (2015-03-02 19:18:19 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld