lib/icon.js - Issue 6318719470927872: Noissue - Fixed documentation where parameters where mistakently indicated as optional

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/icon.js

Issue 6318719470927872: Noissue - Fixed documentation where parameters where mistakently indicated as optional (Closed)

Patch Set: Created Feb. 28, 2015, 5:21 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/icon.js

===================================================================

--- a/lib/icon.js

+++ b/lib/icon.js

@@ -88,8 +88,8 @@

* Set the browser action icon for the given page, indicating whether

* adblocking is active there, and considering the icon animation.

- * @param {Page} [page] The page to set the browser action icon for

- * @param {Boolean} [whitelisted] Whether the page has been whitelisted

+ * @param {Page} page The page to set the browser action icon for

+ * @param {Boolean} whitelisted Whether the page has been whitelisted

function updateIcon(page, whitelisted)

{

@@ -101,7 +101,7 @@

/**

* Starts to animate the browser action icon to indicate a pending notifcation.

- * @param {string} [type] The notifaction type (i.e: "information" or "critical")

+ * @param {string} type The notifaction type (i.e: "information" or "critical")

kzar 2015/03/02 17:09:21 Nit: "notifaction" looks like a typo.

Sebastian Noack 2015/03/02 17:21:38 Well, this typo isn't matter of this change. But f

function startIconAnimation(type)

{

« no previous file with comments | « no previous file | lib/url.js » ('j') | no next file with comments »