Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/icon.js

Issue 6318719470927872: Noissue - Fixed documentation where parameters where mistakently indicated as optional (Closed)
Patch Set: Created Feb. 28, 2015, 5:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/url.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/icon.js
===================================================================
--- a/lib/icon.js
+++ b/lib/icon.js
@@ -88,8 +88,8 @@
* Set the browser action icon for the given page, indicating whether
* adblocking is active there, and considering the icon animation.
*
- * @param {Page} [page] The page to set the browser action icon for
- * @param {Boolean} [whitelisted] Whether the page has been whitelisted
+ * @param {Page} page The page to set the browser action icon for
+ * @param {Boolean} whitelisted Whether the page has been whitelisted
*/
function updateIcon(page, whitelisted)
{
@@ -101,7 +101,7 @@
/**
* Starts to animate the browser action icon to indicate a pending notifcation.
*
- * @param {string} [type] The notifaction type (i.e: "information" or "critical")
+ * @param {string} type The notifaction type (i.e: "information" or "critical")
kzar 2015/03/02 17:09:21 Nit: "notifaction" looks like a typo.
Sebastian Noack 2015/03/02 17:21:38 Well, this typo isn't matter of this change. But f
*/
function startIconAnimation(type)
{
« no previous file with comments | « no previous file | lib/url.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld