Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6327452271902720: Pass return value of ext.onMessage listener through to chrome.runtime.onMessage (Closed)

Created:
April 14, 2014, 9:12 a.m. by Sebastian Noack
Modified:
April 14, 2014, 9:30 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This regression was introduced by http://codereview.adblockplus.org/5464830253203456/ and broke the "Block Element" functionality in Chrome as reported by https://issues.adblockplus.org/ticket/318.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/ext/common.js View 1 chunk +1 line, -1 line 0 comments Download
M ext/common.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
April 14, 2014, 9:21 a.m. (2014-04-14 09:21:39 UTC) #1
Wladimir Palant
April 14, 2014, 9:30 a.m. (2014-04-14 09:30:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld