Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6331143469137920: Issue 206 - Add a pref for suppressing the first run page (Closed)

Created:
March 19, 2015, 6:06 p.m. by Felix Dahlke
Modified:
March 19, 2015, 9:38 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 206 - Add a pref for suppressing the first run page

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M defaults/prefs.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/ui.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Felix Dahlke
Planning to add this under "internal preferences" here once pushed: https://adblockplus.org/en/preferences
March 19, 2015, 6:08 p.m. (2015-03-19 18:08:48 UTC) #1
Wladimir Palant
LGTM On 2015/03/19 18:08:48, Felix H. Dahlke wrote: > Planning to add this under "internal ...
March 19, 2015, 7:03 p.m. (2015-03-19 19:03:12 UTC) #2
Felix Dahlke
March 19, 2015, 9:38 p.m. (2015-03-19 21:38:46 UTC) #3
On 2015/03/19 19:03:12, Wladimir Palant wrote:
> LGTM
> 
> On 2015/03/19 18:08:48, Felix H. Dahlke wrote:
> > Planning to add this under "internal preferences" here once pushed:
> > https://adblockplus.org/en/preferences
> 
> I'd rather create a new section for it, "Preferences for administrators"
maybe?

Alright, done: https://adblockplus.org/en/preferences

Haven't been able to figure out how to move that new section up, however. Should
be above "Internal preferences" IMO.

Powered by Google App Engine
This is Rietveld