Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6349778342379520: Issue 1048 - Fix Android update manifest format (Closed)

Created:
Sept. 18, 2014, 3:42 p.m. by Felix Dahlke
Modified:
Sept. 23, 2014, 8:11 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1048 - Fix Android update manifest format

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove pointless del, don't hard code basename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M sitescripts/extensions/bin/updateUpdateManifests.py View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Sept. 18, 2014, 3:43 p.m. (2014-09-18 15:43:46 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6349778342379520/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py File sitescripts/extensions/bin/updateUpdateManifests.py (right): http://codereview.adblockplus.org/6349778342379520/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py#newcode110 sitescripts/extensions/bin/updateUpdateManifests.py:110: 'adblockplusandroid': { This shouldn't be hardcoded. Please add a ...
Sept. 18, 2014, 6:49 p.m. (2014-09-18 18:49:40 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/6349778342379520/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py File sitescripts/extensions/bin/updateUpdateManifests.py (right): http://codereview.adblockplus.org/6349778342379520/diff/5629499534213120/sitescripts/extensions/bin/updateUpdateManifests.py#newcode110 sitescripts/extensions/bin/updateUpdateManifests.py:110: 'adblockplusandroid': { On 2014/09/18 18:49:40, Wladimir Palant wrote: > ...
Sept. 19, 2014, 2:25 a.m. (2014-09-19 02:25:52 UTC) #3
Wladimir Palant
Sept. 22, 2014, 6:24 p.m. (2014-09-22 18:24:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld