Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/updateUpdateManifests.py

Issue 6349778342379520: Issue 1048 - Fix Android update manifest format (Closed)
Patch Set: Created Sept. 18, 2014, 3:42 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/updateUpdateManifests.py
===================================================================
--- a/sitescripts/extensions/bin/updateUpdateManifests.py
+++ b/sitescripts/extensions/bin/updateUpdateManifests.py
@@ -45,6 +45,7 @@
return {
'revision': revision,
+ 'version': version,
'minSdkVersion': get_min_sdk_version(repo, version),
}
elif repo.type == 'safari':
@@ -104,7 +105,15 @@
if repoType == 'android':
newManifestPath = get_config().get("extensions",
"androidNewUpdateManifestPath")
- writeLibabpUpdateManifest(newManifestPath, extensions[repoType])
+ data = extensions[repoType][0]
+ updates = {
+ 'adblockplusandroid': {
Wladimir Palant 2014/09/18 18:49:40 This shouldn't be hardcoded. Please add a basename
Felix Dahlke 2014/09/19 02:25:52 Done.
+ 'version': data['version'],
+ 'url': data['updateURL']
+ }
+ }
+ writeLibabpUpdateManifest(newManifestPath, updates)
+ del data['version']
Wladimir Palant 2014/09/18 18:49:40 This shouldn't be necessary, the template will ign
Felix Dahlke 2014/09/19 02:25:52 Done.
template = get_template(get_config().get('extensions', '%sUpdateManifest' % repoType))
template.stream({'extensions': extensions[repoType]}).dump(manifestPath)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld