mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png - Issue 6349873972510720: Add the Adblock Browser branding

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png

Issue 6349873972510720: Add the Adblock Browser branding (Closed)

Patch Set: Created Nov. 19, 2014, 1:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 ../drawable-xxhdpi/icon.png
	Wladimir Palant 2014/11/19 15:52:11 Is that a symbolic link? Having symbolic links in Is that a symbolic link? Having symbolic links in a repository isn't a good idea, that will cause all kinds of compatibility issues (most trivial one being Windows lacking support for symbolic links). Felix Dahlke 2014/11/19 15:53:09 Yes, it is one. Did it the same way as Mozilla, th Show quoted text On 2014/11/19 15:52:11, Wladimir Palant wrote: > Is that a symbolic link? Having symbolic links in a repository isn't a good > idea, that will cause all kinds of compatibility issues (most trivial one being > Windows lacking support for symbolic links). Yes, it is one. Did it the same way as Mozilla, they use the same symlinks here.
OLD	NEW