Add the Adblock Browser branding

Add the Adblock Browser branding

[Felix Dahlke, 2014-11-19 13:55:06]

Finally managed to push the new repo for Adblock Browser based on Firefox 34 -
this is our initial commit which applies our branding.

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
File mobile/android/branding/adblockbrowser/configure.sh (right):

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
mobile/android/branding/adblockbrowser/configure.sh:8: MOZ_ANDROID_ANR_REPORTER=
This disables the updater and ANR reporter (reports hanging) for now. Both are
usually only active in Nightly and Aurora IIRC.

[Felix Dahlke, 2014-11-19 15:41:44]

Seems like applying the patch didn't work as expected, the icons are missing.
The icons included here (large_icon.png) are symlinks, but for some reason the
patch turned them into text files.

I cannot manage to upload the full patch with the icons for some reason
(probably having to do with my connection). So please see the full listing
instead:

mobile/android/branding/adblockbrowser/res/drawable-hdpi:
total 80
-rw-r--r--  1 fhd  staff  26074 19 Nov 16:06 icon.png
lrwxr-xr-x  1 fhd  staff     27 19 Nov 16:18 large_icon.png ->
../drawable-xxhdpi/icon.png
-rw-r--r--  1 fhd  staff   5214 19 Nov 16:28 widget_icon.png

mobile/android/branding/adblockbrowser/res/drawable-mdpi:
total 72
-rw-r--r--  1 fhd  staff  22447 19 Nov 16:06 icon.png
lrwxr-xr-x  1 fhd  staff     26 19 Nov 16:19 large_icon.png ->
../drawable-xhdpi/icon.png
-rw-r--r--  1 fhd  staff   4510 19 Nov 16:29 widget_icon.png

mobile/android/branding/adblockbrowser/res/drawable-xhdpi:
total 96
-rw-r--r--  1 fhd  staff  30023 19 Nov 16:06 icon.png
lrwxr-xr-x  1 fhd  staff     28 19 Nov 16:19 large_icon.png ->
../drawable-xxxhdpi/icon.png
-rw-r--r--  1 fhd  staff   3378 19 Nov 16:36 launcher_widget.png
-rw-r--r--  1 fhd  staff   6052 19 Nov 16:34 widget_icon.png

mobile/android/branding/adblockbrowser/res/drawable-xxhdpi:
total 136
-rw-r--r--  1 fhd  staff  39386 19 Nov 16:06 icon.png
-rw-r--r--  1 fhd  staff  20297 19 Nov 16:32 large_icon.png
-rw-r--r--  1 fhd  staff   7640 19 Nov 16:33 widget_icon.png

mobile/android/branding/adblockbrowser/res/drawable-xxxhdpi:
total 80
-rw-r--r--  1 fhd  staff  39625 19 Nov 16:30 icon.png

[Wladimir Palant, 2014-11-19 15:52:11]

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
File mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png
(right):

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png:1:
../drawable-xxhdpi/icon.png
Is that a symbolic link? Having symbolic links in a repository isn't a good
idea, that will cause all kinds of compatibility issues (most trivial one being
Windows lacking support for symbolic links).

[Felix Dahlke, 2014-11-19 15:53:09]

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
File mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png
(right):

http://codereview.adblockplus.org/6349873972510720/diff/5629499534213120/mobi...
mobile/android/branding/adblockbrowser/res/drawable-hdpi/large_icon.png:1:
../drawable-xxhdpi/icon.png
On 2014/11/19 15:52:11, Wladimir Palant wrote:
> Is that a symbolic link? Having symbolic links in a repository isn't a good
> idea, that will cause all kinds of compatibility issues (most trivial one
being
> Windows lacking support for symbolic links).

Yes, it is one. Did it the same way as Mozilla, they use the same symlinks here.

[Felix Dahlke, 2014-11-24 05:06:08]

Do you think you guys could give this a quick review? It's a prerequisite for
all other changes, and there's not even code in it.

I've just added the images made by Sven with minor modifications. All the
non-image files under mobile/android/branding were copied from the Nightly
theme, adjusted where necessary.

[Wladimir Palant, 2014-11-24 12:46:32]

I can't say I like the symbolic links (whether Mozilla uses them in their
repository or not) but LGTM.

[René Jeschke, 2014-11-24 12:47:49]

On 2014/11/24 12:46:32, Wladimir Palant wrote:
> I can't say I like the symbolic links (whether Mozilla uses them in their
> repository or not) but LGTM.

Yes, same here and also LGTM

[Felix Dahlke, 2014-11-25 17:03:02]

Ignoring those comments for the sake of progess, pushed :D

On a more serious note, there _will_ be a review for using the real branding, we
can drop the symlinks then just as well.