Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6399658096066560: Issue 2538 - Register onHeadersReceived event listener only for main_frame and sub_frame requests (Closed)

Created:
May 18, 2015, 2:46 p.m. by Sebastian Noack
Modified:
May 18, 2015, 3:18 p.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2538 - Register onHeadersReceived event listener only for main_frame and sub_frame requests

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M webrequest.js View 2 chunks +8 lines, -7 lines 1 comment Download

Messages

Total messages: 3
Sebastian Noack
http://codereview.adblockplus.org/6399658096066560/diff/5629499534213120/webrequest.js File webrequest.js (left): http://codereview.adblockplus.org/6399658096066560/diff/5629499534213120/webrequest.js#oldcode89 webrequest.js:89: if (details.tabId == -1) There should always be a ...
May 18, 2015, 2:48 p.m. (2015-05-18 14:48:49 UTC) #1
Sebastian Noack
May 18, 2015, 2:49 p.m. (2015-05-18 14:49:02 UTC) #2
Thomas Greiner
May 18, 2015, 3:17 p.m. (2015-05-18 15:17:34 UTC) #3
Nice one, LGTM

Powered by Google App Engine
This is Rietveld