Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6406754824880128: Issue 2038 - Convert palette images with transparency to RGBA before pasting (Closed)

Created:
Feb. 24, 2015, 3:53 p.m. by Sebastian Noack
Modified:
March 2, 2015, 12:15 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2038 - Convert palette images with transparency to RGBA before pasting

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixed typo in comment #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M imageConversion.py View 1 2 2 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Feb. 24, 2015, 3:57 p.m. (2015-02-24 15:57:36 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6406754824880128/diff/5629499534213120/imageConversion.py File imageConversion.py (right): http://codereview.adblockplus.org/6406754824880128/diff/5629499534213120/imageConversion.py#newcode60 imageConversion.py:60: # specified in bytes (pngout loves to that shit), ...
Feb. 24, 2015, 5:08 p.m. (2015-02-24 17:08:12 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6406754824880128/diff/5629499534213120/imageConversion.py File imageConversion.py (right): http://codereview.adblockplus.org/6406754824880128/diff/5629499534213120/imageConversion.py#newcode60 imageConversion.py:60: # specified in bytes (pngout loves to that shit), ...
Feb. 24, 2015, 5:19 p.m. (2015-02-24 17:19:23 UTC) #3
Wladimir Palant
Feb. 24, 2015, 5:23 p.m. (2015-02-24 17:23:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld