Issue 301 - adblockplustests: Use for (.. of ..)

chrome/content/tests/notification.js

 (function()
 {
   let testRunner = null;
   let randomResult = 0.5;
 
   let originalInfo;
   let info = require("info");
 
   module("Notification handling",
   {
@@ skipping 159 matching lines @@
       ["platformMinVersion", "12", true],
       ["platformMinVersion", "11", true],
       ["platformMinVersion", "13", false],
       ["platformMinVersion", "12.1", false],
       ["platformMaxVersion", "12.0", true],
       ["platformMaxVersion", "12", true],
       ["platformMaxVersion", "13", true],
       ["platformMaxVersion", "11", false],
     ];
 
-    for each (let [propName, value, result] in targets)
+    for (let [propName, value, result] of targets)
     {
       let targetInfo = {};
       targetInfo[propName] = value;
 
       let information = fixConstructors({
         id: 1,
         type: "information",
         message: {"en-US": "Information"},
         targets: [targetInfo]
       });
 
       Prefs.notificationdata = {};
       registerHandler([information]);
       testRunner.runScheduledTasks(1);
 
       let expected = (result ? information : null);
       deepEqual(Notification.getNextToShow(), expected, "Selected notification for " + JSON.stringify(information.targets));
       deepEqual(Notification.getNextToShow(), null, "No notification on second call");
     }
 
     function pairs(array)
     {
-      for each (let element1 in array)
-        for each (let element2 in array)
+      for (let element1 of array)
+        for (let element2 of array)
           yield [element1, element2];
     }
     for (let [[propName1, value1, result1], [propName2, value2, result2]] in pairs(targets))
     {
       let targetInfo1 = {};
       targetInfo1[propName1] = value1;
       let targetInfo2 = {};
       targetInfo2[propName2] = value2;
 
       let information = fixConstructors({
@@ skipping 81 matching lines @@
       {
         randomResult: 0.5,
         skipAfter: 5.2,
         skip: 30,               // Long break should increase soft expiration, hitting hard expiration
         requests: [0.2, 48.2]
       }
     ];
 
     let requests = [];
     registerHandler([], function(metadata) requests.push(testRunner.getTimeOffset()));
-    for each (let test in tests)
+    for (let test of tests)
     {
       Prefs.notificationdata = {};
       requests = [];
       randomResult = test.randomResult;
 
       let maxHours = Math.round(Math.max.apply(null, test.requests)) + 1;
       testRunner.runScheduledTasks(maxHours, test.skipAfter, test.skip);
 
       let skipAddendum = (typeof test.skip != "number" ? "" : " skipping " + test.skip + " hours after " + test.skipAfter + " hours");
       deepEqual(requests, test.requests, "Requests with Math.random() returning " + randomResult + skipAddendum);
@@ skipping 86 matching lines @@
     equal(texts.message, "fr");
   });
 
   test("Missing translation", function()
   {
     let notification = {message: {"en-US": "en-US"}};
     let texts = Notification.getLocalizedTexts(notification, "fr");
     equal(texts.message, "en-US");
   });
 })();