Issue 6423769060999168: Issue 301 - adblockplustests: Use for (.. of ..)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6423769060999168: Issue 301 - adblockplustests: Use for (.. of ..) (Closed)

Created:
April 12, 2014, 1:48 p.m. by tschuster

Modified:
April 14, 2014, 6 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Running the tests seems to work, so this should be fine. The buildtools subrepo needs to be updated

Patch Set 1 #

Created: April 12, 2014, 1:48 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -41 lines)			Patch
M	chrome/content/common.js	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/content/index.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/elemhide.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/filterClasses.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/content/tests/filterListener.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/content/tests/filterNotifier.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/filterStorage_readwrite.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/content/tests/matcher.js	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/tests/notification.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/tests/performance/common.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/performance/filter_fromText.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/performance/matcher_init.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/performance/matching.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/content/tests/performance/page_load_overhead.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/tests/popupBlocker.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/subscriptionClasses.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/tests/synchronizer.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/tests/test_requestList.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages