issue 449 - override toolbar icon context menu if left click action is redefined

this review is related to current ticket:
https://issues.adblockplus.org/ticket/449

[saroyanm, 2014-05-14 16:09:55]

@Wladimir can you please have a look.

[Wladimir Palant, 2014-05-14 18:12:55]

This is fine but what about the status bar icon that exists in SeaMonkey for
example? The behavior should be consistent there.

[saroyanm, 2014-05-14 18:56:15]

On 2014/05/14 18:12:55, Wladimir Palant wrote:
> This is fine but what about the status bar icon that exists in SeaMonkey for
> example? The behavior should be consistent there.

Seams like SeaMonkey don't have default context menu for statusbarpanel, What
you think Wladimir make sense to remove it, or have some other context menu ?
Anyway in this case maybe we can stick to having popup on right click in
SeaMonkey ?

[Wladimir Palant, 2014-05-15 06:55:35]

On 2014/05/14 18:56:15, saroyanm wrote:
> Anyway in this case maybe we can stick to having popup on right click in
> SeaMonkey ?

We should only have the popup on right click if it isn't the left click action
already - for consistency. It doesn't matter that there is no default context
menu.

[saroyanm, 2014-05-15 09:15:18]

On 2014/05/15 06:55:35, Wladimir Palant wrote:
> On 2014/05/14 18:56:15, saroyanm wrote:
> > Anyway in this case maybe we can stick to having popup on right click in
> > SeaMonkey ?
> 
> We should only have the popup on right click if it isn't the left click action
> already - for consistency. It doesn't matter that there is no default context
> menu.

Thanks for your message Wladimir, got the idea,
I've updated the patch.
Hope this will work for us.

[Wladimir Palant, 2014-05-15 10:19:44]

LGTM