Issue 2434 - Fixed: Custom filters and global functions can not be instance methods

Issue 2434 - Fixed: Custom filters and global functions can not be instance methods

[Wladimir Palant, 2015-04-29 17:37:25]

LGTM

[Sebastian Noack, 2015-04-30 12:36:31]

I've uploaded a new patch. I think we have to record the module regardless
whether we have a callable here. Imagine following case for example:

  import foo
  my_global = {"bar": foo.bar()}

Also less checks means less complexity.

[Sebastian Noack, 2015-04-30 12:48:52]

I meant:

  my_global = {"bar": lambda : foo.bar()}

[Wladimir Palant, 2015-04-30 15:52:02]

On 2015/04/30 12:36:31, Sebastian Noack wrote:
> I've uploaded a new patch. I think we have to record the module regardless
> whether we have a callable here. Imagine following case for example:
> 
>   import foo
>   my_global = {"bar": foo.bar()}

This call will happen while the module loads, no issue here. I guess you meant:

   my_global = {"bar": lambda x: foo.bar(x)}

> Also less checks means less complexity.

I agree, I only added this check because adding a property to primitives wasn't
possible.

LGTM

[Sebastian Noack, 2015-04-30 17:55:59]

On 2015/04/30 15:52:02, Wladimir Palant wrote:
> This call will happen while the module loads, no issue here. I guess you
meant:
> 
>    my_global = {"bar": lambda x: foo.bar(x)}

I did, see my follow-up comment above.