Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6445129351036928: Noissue - Fixed issue where JsDoc documented module functions incorrectly (Closed)

Created:
April 15, 2015, 3:52 p.m. by Sebastian Noack
Modified:
April 21, 2015, 11:30 a.m.
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

JsDoc is only able to automatically recognize static module functions when defined like: exports.foo = function() {}; For more details, see https://github.com/jsdoc3/jsdoc/issues/985.

Patch Set 1 #

Patch Set 2 : Fixed syntax error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -38 lines) Patch
M lib/filterComposer.js View 4 chunks +4 lines, -3 lines 0 comments Download
M lib/filterValidation.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/icon.js View 2 chunks +6 lines, -9 lines 0 comments Download
M lib/stats.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/url.js View 7 chunks +7 lines, -10 lines 0 comments Download
M lib/whitelisting.js View 1 8 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
April 15, 2015, 3:54 p.m. (2015-04-15 15:54:42 UTC) #1
kzar
I feel like this is probably a big enough change to warrant an issue. What ...
April 16, 2015, 12:17 p.m. (2015-04-16 12:17:56 UTC) #2
Sebastian Noack
On 2015/04/16 12:17:56, kzar wrote: > I feel like this is probably a big enough ...
April 16, 2015, 12:49 p.m. (2015-04-16 12:49:21 UTC) #3
kzar
Fair enough, LGTM but please do test as well.
April 16, 2015, 1:35 p.m. (2015-04-16 13:35:53 UTC) #4
Sebastian Noack
I still found a silly syntax error.
April 18, 2015, 2:55 p.m. (2015-04-18 14:55:57 UTC) #5
kzar
April 21, 2015, 11:30 a.m. (2015-04-21 11:30:49 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld