Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(440)

Issue 6453924974297088: Issue 1619 - Wrong return value of CPluginClass::Invoke (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by sergei
Modified:
5 years, 1 month ago
Reviewers:
Eric, Oleksandr
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : clean CPluginClass::Invoke #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -80 lines) Patch
M src/plugin/PluginClass.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginClass.cpp View 1 5 chunks +15 lines, -79 lines 5 comments Download

Messages

Total messages: 5
sergei
5 years, 2 months ago (2014-11-26 20:52:34 UTC) #1
Oleksandr
http://codereview.adblockplus.org/6453924974297088/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/6453924974297088/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode632 src/plugin/PluginClass.cpp:632: return VARIANT_TRUE; How about returns here? In fact most ...
5 years, 2 months ago (2014-11-27 09:52:56 UTC) #2
Oleksandr
LGTM
5 years, 2 months ago (2014-11-27 13:49:38 UTC) #3
Eric
http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (right): http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/plugin/PluginClass.cpp#newcode661 src/plugin/PluginClass.cpp:661: ATL::CComPtr<IWebBrowser2> browser = GetBrowser(); We could declare this as ...
5 years, 1 month ago (2014-12-30 14:37:50 UTC) #4
sergei
5 years, 1 month ago (2015-01-13 13:24:21 UTC) #5
I'm closing it because http://codereview.adblockplus.org/4937147073167360/
supersedes it.

http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/6453924974297088/diff/5649050225344512/src/...
src/plugin/PluginClass.cpp:661: ATL::CComPtr<IWebBrowser2> browser =
GetBrowser();
On 2014/12/30 14:37:50, Eric wrote:
> We could declare this as IWebBrowser2* with one small modification below.

I find it as a bad practice, `GetBrowser()` returns smart pointer, if we store
merely raw pointer the smart pointer object is destroyed. It works here but it
smells a lot.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5