Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

lib/main.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 Cu.import("resource://gre/modules/Services.jsm");
 
 let {Prefs} = require("prefs");
 let {WindowObserver} = require("windowObserver");
 let {WindowWrapper} = require("windowWrapper");
 
 // Check whether some preferences can still be found under their old locations
 Prefs.migrate("extensions.adblockplus.ehh-selectelement_key", "selectelement_key");
 Prefs.migrate("extensions.adblockplus.ehh.showhelp", "showhelp");
 
 // Window types to attach to
-let knownWindowTypes =
-{
-  "navigator:browser": true,
-  "mail:3pane": true,
-  "mail:messageWindow": true,
-  __proto__: null
-};
+let knownWindowTypes = Object.create(null);

[Wladimir Palant, 2015/04/01 19:01:14]

Better: Set(["navigator:browser", "mail:3pane", "mail:messageWindow"])

This will however require replacing |type in knownWindowTypes| by
|knownWindowTypes.has(type)| below.

[Sebastian Noack, 2015/04/02 07:19:47]

True.

+knownWindowTypes["navigator:browser"] = true;
+knownWindowTypes["mail:3pane"] = true;
+knownWindowTypes["mail:messageWindow"] = true;
 
 // Use random marker class
 let elementMarkerClass = null;
 {
   let rnd = [];
   let offset = "a".charCodeAt(0);
   for (let i = 0; i < 20; i++)
     rnd.push(offset + Math.random() * 26);
 
   elementMarkerClass = String.fromCharCode.apply(String, rnd);
 }
 exports.elementMarkerClass = elementMarkerClass;
 
 // Load CSS asynchronously
 let request = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].createInstance(Ci.nsIXMLHttpRequest);
 request.open("GET", "chrome://elemhidehelper/content/elementmarker.css");
 request.overrideMimeType("text/plain");
 request.addEventListener("load", function(event)
 {
   if (onShutdown.done)
     return;
 
   let data = event.target.responseText.replace(/%%CLASS%%/g, elementMarkerClass);
   let styleService = Cc["@mozilla.org/content/style-sheet-service;1"].getService(Ci.nsIStyleSheetService);
   let styleURI = Services.io.newURI("data:text/css," + encodeURIComponent(data), null, null);
   styleService.loadAndRegisterSheet(styleURI, Ci.nsIStyleSheetService.USER_SHEET);
-  onShutdown.add(function() styleService.unregisterSheet(styleURI, Ci.nsIStyleSheetService.USER_SHEET));
+  onShutdown.add(() => styleService.unregisterSheet(styleURI, Ci.nsIStyleSheetService.USER_SHEET));
 }, false);
 request.send(null);
 
 // Load overlay asynchonously and start attaching to windows once done
 request = Cc["@mozilla.org/xmlextras/xmlhttprequest;1"].createInstance(Ci.nsIJSXMLHttpRequest);
 request.open("GET", "chrome://elemhidehelper/content/overlay.xul");
 request.addEventListener("load", function(event)
 {
   if (onShutdown.done)
     return;
@@ skipping 29 matching lines @@
       if (element)
         element.parentNode.removeChild(element);
 
       for (let child = window.document.firstChild; child; child = child.nextSibling)
         if (child.nodeType == child.PROCESSING_INSTRUCTION_NODE && child.data.indexOf("elemhidehelper-node") >= 0)
           child.parentNode.removeChild(child);
     }
   });
 }, false);
 request.send(null);