Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper (Closed)

Created:
April 1, 2015, 3:16 p.m. by Sebastian Noack

Modified:
April 29, 2015, 2:38 p.m.

Reviewers:
tschuster, Wladimir Palant

Visibility:
Public.

Description

Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

Patch Set 2 : Use a Set instead an object #

Patch Set 3 : Turned knownClasses into a Set as well #

Total comments: 1

Created: April 4, 2015, 3:28 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -28 lines)			Patch
M	chrome/content/composer.js	View	1 2	2 chunks	+7 lines, -11 lines	1 comment	Download
M	lib/aardvark.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/inspectorObserver.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/main.js	View	1	3 chunks	+3 lines, -9 lines	0 comments	Download
M	lib/windowWrapper.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/6520005931827200/diff/5629499534213120/lib/main.js File lib/main.js (right): http://codereview.adblockplus.org/6520005931827200/diff/5629499534213120/lib/main.js#newcode18 lib/main.js:18: let knownWindowTypes = Object.create(null); Better: Set(["navigator:browser", "mail:3pane", "mail:messageWindow"]) This ...

April 1, 2015, 7:01 p.m. (2015-04-01 19:01:14 UTC) #2

Sebastian Noack

April 2, 2015, 7:19 a.m. (2015-04-02 07:19:47 UTC) #3

Sebastian Noack

http://codereview.adblockplus.org/6520005931827200/diff/5657382461898752/chrome/content/composer.js File chrome/content/composer.js (right): http://codereview.adblockplus.org/6520005931827200/diff/5657382461898752/chrome/content/composer.js#newcode251 chrome/content/composer.js:251: let knownClasses = new Set(attr.value.split(/\s+/)); While introducing Sets and ...

April 4, 2015, 3:30 p.m. (2015-04-04 15:30:21 UTC) #5

LGTM

Expand All Messages | Collapse All Messages