Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

lib/aardvark.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let {Prefs} = require("prefs");
 
 // Make sure to stop selection when we are uninstalled
-onShutdown.add(function() Aardvark.quit());
+onShutdown.add(() => Aardvark.quit());
 
 // To be replaced when selection starts
 function E(id) {return null;}
 
 /*********************************
  * Minimal element creation code *
  *********************************/
 
 function createElement(doc, tagName, attrs, children)
 {
@@ skipping 32 matching lines @@
   start: function(wrapper)
   {
     if (!this.canSelect(wrapper.browser))
       return;
 
     if (this.browser)
       this.quit();
 
     this.window = wrapper.window;
     this.browser = wrapper.browser;
-    E = function(id) wrapper.E(id);
+    E = id => wrapper.E(id);
 
     this.browser.addEventListener("click", this.onMouseClick, true);
     this.browser.addEventListener("DOMMouseScroll", this.onMouseScroll, true);
     this.browser.addEventListener("keypress", this.onKeyPress, true);
     this.browser.addEventListener("mousemove", this.onMouseMove, true);
     this.browser.addEventListener("select", this.quit, false);
     this.browser.contentWindow.addEventListener("pagehide", this.onPageHide, true);
 
     this.browser.contentWindow.focus();
 
@@ skipping 482 matching lines @@
     this.browser.removeEventListener("select", this.quit, false);
     this.browser.contentWindow.removeEventListener("pagehide", this.onPageHide, true);
 
     this.anchorElem = null;
     this.selectedElem = null;
     this.window = null;
     this.browser = null;
     this.commentElem = null;
     this.lockedAnchor = null;
     this.boxElem = null;
-    E = function(id) null;
+    E = id => null;
     return false;
   },
 
   select: function(elem)
   {
     if (!elem)
       return false;
 
     this.window.openDialog("chrome://elemhidehelper/content/composer.xul", "_blank",
                            "chrome,centerscreen,resizable,dialog=no", elem);
@@ skipping 168 matching lines @@
     }
 
     // Show help box
     helpBox.showPopup(this.browser, -1, -1, "tooltip", "topleft", "topleft");
     return true;
   }
 }
 
 // Makes sure event handlers like Aardvark.onKeyPress always have the correct
 // this pointer set.
-for each (let method in ["onMouseClick", "onMouseScroll", "onKeyPress", "onPageHide", "onMouseMove", "onAfterPaint", "quit"])
+for (let method of ["onMouseClick", "onMouseScroll", "onKeyPress", "onPageHide", "onMouseMove", "onAfterPaint", "quit"])
   Aardvark[method] = Aardvark[method].bind(Aardvark);