lib/aardvark.js - Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/aardvark.js

Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper (Closed)

Patch Set: Turned knownClasses into a Set as well Created April 4, 2015, 3:28 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/aardvark.js

===================================================================

--- a/lib/aardvark.js

+++ b/lib/aardvark.js

@@ -7,7 +7,7 @@

let {Prefs} = require("prefs");

// Make sure to stop selection when we are uninstalled

-onShutdown.add(function() Aardvark.quit());

+onShutdown.add(() => Aardvark.quit());

// To be replaced when selection starts

function E(id) {return null;}

@@ -60,7 +60,7 @@

this.window = wrapper.window;

this.browser = wrapper.browser;

- E = function(id) wrapper.E(id);

+ E = id => wrapper.E(id);

this.browser.addEventListener("click", this.onMouseClick, true);

this.browser.addEventListener("DOMMouseScroll", this.onMouseScroll, true);

@@ -563,7 +563,7 @@

this.commentElem = null;

this.lockedAnchor = null;

this.boxElem = null;

- E = function(id) null;

+ E = id => null;

return false;

@@ -752,5 +752,5 @@

// Makes sure event handlers like Aardvark.onKeyPress always have the correct

// this pointer set.

-for each (let method in ["onMouseClick", "onMouseScroll", "onKeyPress", "onPageHide", "onMouseMove", "onAfterPaint", "quit"])

+for (let method of ["onMouseClick", "onMouseScroll", "onKeyPress", "onPageHide", "onMouseMove", "onAfterPaint", "quit"])

Aardvark[method] = Aardvark[method].bind(Aardvark);