lib/inspectorObserver.js - Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/inspectorObserver.js

Issue 6520005931827200: Issue 2259 - Removed non-standard JavaScript code from Element Hiding Helper (Closed)

Patch Set: Use a Set instead an object Created April 2, 2015, 7:19 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/inspectorObserver.js

===================================================================

--- a/lib/inspectorObserver.js

+++ b/lib/inspectorObserver.js

@@ -32,8 +32,7 @@

let stringBundle = Services.strings.createBundle("chrome://elemhidehelper/locale/global.properties?" + Math.random());

let result = stringBundle.GetStringFromName("inspector.button.tooltiptext");

- delete this.inspectorButtonTooltip;

- this.__defineGetter__("inspectorButtonTooltip", function() result);

+ Object.defineProperty(this, "inspectorButtonTooltip", {value: result, enumerable: true});

return this.inspectorButtonTooltip;

« no previous file with comments | « lib/aardvark.js ('k') | lib/main.js » ('j') | no next file with comments »