Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6525035187535872: issue #390 - Integrate parts of Element Hiding Helper functionality into Adblock Plus (Closed)

Created:
July 18, 2014, 12:54 p.m. by saroyanm
Modified:
March 15, 2017, 3:14 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This review is related to current issue: https://issues.adblockplus.org/ticket/390

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -0 lines) Patch
A chrome/content/ui/ehh-composer.js View 1 chunk +645 lines, -0 lines 2 comments Download
A chrome/content/ui/ehh-composer.xul View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/locale/en-US/ehh-composer.dtd View 1 chunk +21 lines, -0 lines 1 comment Download
M chrome/locale/en-US/global.properties View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/skin/devToolsOverlay.css View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/skin/ehh-composer.css View 1 chunk +49 lines, -0 lines 0 comments Download
M defaults/prefs.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/ui.js View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 2
saroyanm
Wladimir, can you please have a look on current review, when you have time. http://codereview.adblockplus.org/6525035187535872/diff/5629499534213120/chrome/content/ui/ehh-composer.js ...
July 18, 2014, 1:14 p.m. (2014-07-18 13:14:41 UTC) #1
Wladimir Palant
March 15, 2017, 3:14 p.m. (2017-03-15 15:14:42 UTC) #2
I'm closing this review, it won't happen any more with the Web Extensions move.

Powered by Google App Engine
This is Rietveld