Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: createsolution.bat

Issue 6584950149087232: Issue 1280 - Update v8 (Closed)
Patch Set: use msvs2012, because firstly it should go into our branch Created Oct. 27, 2014, 3:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: createsolution.bat
===================================================================
--- a/createsolution.bat
+++ b/createsolution.bat
@@ -3,6 +3,6 @@
pushd %~dp0
mkdir build\ia32\shell
mkdir build\x64\shell
-python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator-output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 libadblockplus.gyp
-python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator-output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 libadblockplus.gyp
+python msvs_gyp_wrapper.py --depth=build\ia32 -f msvs -I common.gypi --generator-output=build\ia32 -G msvs_version=2012 -Dtarget_arch=ia32 -Dhost_arch=ia32 libadblockplus.gyp
+python msvs_gyp_wrapper.py --depth=build\x64 -f msvs -I common.gypi --generator-output=build\x64 -G msvs_version=2012 -Dtarget_arch=x64 -Dhost_arch=x64 libadblockplus.gyp
Felix Dahlke 2014/10/31 05:31:57 We generally don't align code in columns, so I'd v
sergei 2014/10/31 11:47:01 I've removed such spaces. Could you explain the ad
Felix Dahlke 2014/10/31 15:07:51 I don't have a strong opinion actually. The only c
sergei 2014/10/31 16:13:35 BTW, don't mix indenting and alignment, here are t
Felix Dahlke 2014/10/31 16:30:15 Yeah, aligning it is.
popd
« no previous file with comments | « common.gypi ('k') | include/AdblockPlus/JsValue.h » ('j') | include/AdblockPlus/JsValue.h » ('J')

Powered by Google App Engine
This is Rietveld