Issue 1847 - Add .gitignore file for Git users

Issue 1847 - Add .gitignore file for Git users

[Wladimir Palant, 2015-01-22 11:08:36]

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
File .hgignore (left):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
.hgignore:6: \.safariextension$
Note that I intentionally removed this one - it's inside the devenv directory
without the latest buildtools changes.

[kzar, 2015-01-22 11:13:01]

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.git...
File .gitignore (right):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.git...
.gitignore:1: /devenv/
You don't need the first "/", although this works too.

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
File .hgignore (right):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
.hgignore:1: ^devenv$
Why not do this rule using glob syntax too to make it more consistent with the
gitignore?

[Wladimir Palant, 2015-01-22 11:39:42]

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.git...
File .gitignore (right):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.git...
.gitignore:1: /devenv/
On 2015/01/22 11:13:01, kzar wrote:
> You don't need the first "/", although this works too.

I do, otherwise /lib/devenv/ will be ignored as well - yet it shouldn't be. From
Git documentation:

> A leading slash matches the beginning of the pathname. For example, "/*.c"
matches "cat-file.c" but not "mozilla-sha1/sha1.c".

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
File .hgignore (right):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
.hgignore:1: ^devenv$
On 2015/01/22 11:13:01, kzar wrote:
> Why not do this rule using glob syntax too to make it more consistent with the
> gitignore?

For the same reason: glob rules in .hgignore don't allow ignoring a directory at
the top-level while still considering it elsewhere.

[kzar, 2015-01-22 11:41:23]

OK, fair enough, I did not realise that. LGTM

[Sebastian Noack, 2015-01-22 11:53:11]

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
File .hgignore (left):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
.hgignore:6: \.safariextension$
On 2015/01/22 11:08:36, Wladimir Palant wrote:
> Note that I intentionally removed this one - it's inside the devenv directory
> without the latest buildtools changes.

With the latest changes it will still be in the devenv director, but merely in a
subfolder there. So removing it should be fine either way.

But while on it, you might want to add .safariextz (signed builds, like .crx for
Chrome).

[Wladimir Palant, 2015-01-22 12:30:09]

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
File .hgignore (left):

http://codereview.adblockplus.org/6601884584378368/diff/5629499534213120/.hgi...
.hgignore:6: \.safariextension$
On 2015/01/22 11:53:11, Sebastian Noack wrote:
> But while on it, you might want to add .safariextz (signed builds, like .crx
for
> Chrome).

Done.

[Sebastian Noack, 2015-01-22 12:49:51]

LGTM