Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6608332739575808: Issue 2301 - Replace links in proxied content (Closed)

Created:
April 16, 2015, 12:39 p.m. by Wladimir Palant
Modified:
April 16, 2015, 6:40 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Issue 2301 - Replace links in proxied content

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
April 16, 2015, 12:39 p.m. (2015-04-16 12:39:34 UTC) #1
mathias
http://codereview.adblockplus.org/6608332739575808/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): http://codereview.adblockplus.org/6608332739575808/diff/5629499534213120/modules/web/templates/adblockplus.org.conf.erb#newcode221 modules/web/templates/adblockplus.org.conf.erb:221: sub_filter https://adblockplus.org/ https://$host/; I understand what you are doing ...
April 16, 2015, 12:44 p.m. (2015-04-16 12:44:14 UTC) #2
mathias
April 16, 2015, 1:50 p.m. (2015-04-16 13:50:19 UTC) #3
LGTM.

http://codereview.adblockplus.org/6608332739575808/diff/5629499534213120/modu...
File modules/web/templates/adblockplus.org.conf.erb (right):

http://codereview.adblockplus.org/6608332739575808/diff/5629499534213120/modu...
modules/web/templates/adblockplus.org.conf.erb:221: sub_filter
https://adblockplus.org/ https://$host/;
On 2015/04/16 12:44:14, matze wrote:
> I understand what you are doing here - but why?

Never mind, I've seen it now.

Powered by Google App Engine
This is Rietveld