Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6627397512200192: Issue 1362 - createNightlies script should call ensure_dependencies (Closed)

Created:
Sept. 11, 2014, 6:18 p.m. by Wladimir Palant
Modified:
Sept. 18, 2014, 7:06 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 1362 - createNightlies script should call ensure_dependencies

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use set literals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M sitescripts/extensions/bin/createNightlies.py View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Sept. 11, 2014, 6:18 p.m. (2014-09-11 18:18:24 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/6627397512200192/diff/5741031244955648/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6627397512200192/diff/5741031244955648/sitescripts/extensions/bin/createNightlies.py#newcode102 sitescripts/extensions/bin/createNightlies.py:102: skipdependencies=set(["buildtools"])) We don't support Python 2.6 anymore, right? Then ...
Sept. 18, 2014, 4:27 p.m. (2014-09-18 16:27:45 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/6627397512200192/diff/5741031244955648/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): http://codereview.adblockplus.org/6627397512200192/diff/5741031244955648/sitescripts/extensions/bin/createNightlies.py#newcode102 sitescripts/extensions/bin/createNightlies.py:102: skipdependencies=set(["buildtools"])) On 2014/09/18 16:27:46, Sebastian Noack wrote: > We ...
Sept. 18, 2014, 6:18 p.m. (2014-09-18 18:18:18 UTC) #3
Sebastian Noack
Sept. 18, 2014, 6:59 p.m. (2014-09-18 18:59:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld