Issue 1613 - Don't collapse elements with non-HTTP URL

include.preload.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
   "iframe": "SUBDOCUMENT"
 };
 
 function checkCollapse(element)
 {
   var tag = element.localName;
   if (tag in typeMap)
   {
     // This element failed loading, did we block it?
     var url = element.src;
-    if (!url)
+    if (!url || !/^https:/i.test(url))

[kzar, 2014/11/26 16:41:10]

Shouldn't we also match HTTP as well as HTTPS here?

[Sebastian Noack, 2014/11/26 16:53:13]

Ouch, this was a typo.

[kzar, 2014/11/26 16:58:29]

Easily done! Works for me now

       return;
 
     ext.backgroundPage.sendMessage(
       {
         type: "should-collapse",
         url: url,
         mediatype: typeMap[tag]
       },
 
       function(response)
@@ skipping 144 matching lines @@
   }, true);
 
   ext.backgroundPage.sendMessage({type: "get-selectors"}, setElemhideCSSRules);
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   init(document);
 }