Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6646117731139584: Issue 1613 - Don't collapse elements with non-HTTP URL (Closed)

Created:
Nov. 26, 2014, 3:06 p.m. by Sebastian Noack
Modified:
Nov. 26, 2014, 5:08 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 1613 - Don't collapse elements with non-HTTP URL

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed typo, also checking for http:// #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include.preload.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Nov. 26, 2014, 3:06 p.m. (2014-11-26 15:06:57 UTC) #1
kzar
http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js#newcode36 include.preload.js:36: if (!url || !/^https:/i.test(url)) Shouldn't we also match HTTP ...
Nov. 26, 2014, 4:41 p.m. (2014-11-26 16:41:10 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js#newcode36 include.preload.js:36: if (!url || !/^https:/i.test(url)) On 2014/11/26 16:41:10, kzar wrote: ...
Nov. 26, 2014, 4:53 p.m. (2014-11-26 16:53:13 UTC) #3
kzar
LGTM http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/6646117731139584/diff/5629499534213120/include.preload.js#newcode36 include.preload.js:36: if (!url || !/^https:/i.test(url)) On 2014/11/26 16:53:13, Sebastian ...
Nov. 26, 2014, 4:58 p.m. (2014-11-26 16:58:29 UTC) #4
Wladimir Palant
Nov. 26, 2014, 5:03 p.m. (2014-11-26 17:03:35 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld