Issue 6668950364487680: Issue 1593 - Extend workaround for Chrome bug breaking Flash videos to Chrome >=38

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6668950364487680: Issue 1593 - Extend workaround for Chrome bug breaking Flash videos to Chrome >=38 (Closed)

Created:
Nov. 22, 2014, 12:19 p.m. by Sebastian Noack

Modified:
Nov. 25, 2014, 5:04 p.m.

Reviewers:
kzar, Wladimir Palant

Visibility:
Public.

Patch Set 1 : #

Total comments: 2

Created: Nov. 24, 2014, 10:12 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/ext/background.js	View		1 chunk	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/6668950364487680/diff/5741031244955648/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/6668950364487680/diff/5741031244955648/chrome/ext/background.js#newcode325 chrome/ext/background.js:325: if (requestType == "other" && parseInt(navigator.userAgent.match(/\bChrome\/(\d+)/)[1], 10) >= 38) ...

Nov. 25, 2014, 4:45 p.m. (2014-11-25 16:45:50 UTC) #3

Sebastian Noack

Nov. 25, 2014, 5:04 p.m. (2014-11-25 17:04:04 UTC) #4

http://codereview.adblockplus.org/6668950364487680/diff/5741031244955648/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/6668950364487680/diff/5741031244955648/chro...
chrome/ext/background.js:325: if (requestType == "other" &&
parseInt(navigator.userAgent.match(/\bChrome\/(\d+)/)[1], 10) >= 38)
On 2014/11/25 16:45:51, Wladimir Palant wrote:
> This will error out if navigator.userAgent.match() returns null (shouldn't
> happen too often but is possible).

Well, in that case parseInt() will return NaN, and |NaN >= 38| returns false.
Therefore this code really is the same as:

  var match = navigator.userAgent.match(/\bChrome\/(\d+)/)[1], 10);
  if (match && parseInt(match[0], 10) >= 38)

> Given that we are in the background page here, why not do
> |Services.vc.compare(require("info").applicationVersion, "38.0") >= 0|?

Because we are in the abstraction layer. That's one reason why I would like to
convert ext into CommonJS modules bundled with our other code, that we can
easier reuse those functions.

Expand All Messages | Collapse All Messages